NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Translation] [LocoProvider] Add content-type for POST translations#45791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.4fromtomasz-kusy:5.4-loco-fix

Mar 26, 2022

Merged

[Translation] [LocoProvider] Add content-type for POST translations#45791

fabpot merged 1 commit intosymfony:5.4fromtomasz-kusy:5.4-loco-fix

Mar 26, 2022

Conversation

Copy link

Contributor

tomasz-kusy commentedMar 19, 2022

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#44031
License	MIT
#44031

[Translation] [LocoProvider] Add content-type for POST translations

be5b274

carsonbot added Status: Needs Review Bug Translation labels

Mar 19, 2022

carsonbot added this to the5.4 milestone

Mar 19, 2022

Copy link

carsonbot commentedMar 20, 2022

Hey!

I think@Kocal has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

Kocal approved these changes

Mar 20, 2022

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Mar 20, 2022

nicolas-grekas reviewed

Mar 22, 2022

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR. Just one comment and good to go on my side.

src/Symfony/Component/Translation/Bridge/Loco/LocoProvider.phpShow resolvedHide resolved

nicolas-grekas mentioned this pull request

Mar 22, 2022

[HttpClient] Improve default content-type handling#45812

Merged

fabpot added a commit that referenced this pull request

Mar 23, 2022

feature#45812[HttpClient] Improve default content-type handling (ni…

f5a8916

…colas-grekas)This PR was merged into the 6.1 branch.Discussion----------[HttpClient] Improve default content-type handling| Q             | A| ------------- | ---| Branch?       | 6.1| Bug fix?      | no| New feature?  | yes (minor)| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -This improves the default behavior of handling the content-type header: with this PR, when an array is passed as body, the content-type is forced to `application/x-www-form-urlencoded`.This allows setting a content-type in the default options and have it overridden when passing an array as body.Spotted while reviewing#45791, where the proposed behavior would have allowed a cleaner patch.Commits-------91099a9 [HttpClient] Improve default content-type handling