Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Fix exit codes in debug:translation command#45787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
The `--only-missing` and `--only-unused` options should be independent ofeach other.When using the `--only-missing` option, only **missing** messagesshould be relevant to the outcome of the execution. If there are nomissing messages, but some unused messages, the execution of the commandwas still successful and no non-zero exit code should be returned.The same applies when using the `--only-unused` option. In this case,only **unused** messages should be relevant to the execution result,even if there are some missing messages.
nicolas-grekas approved these changesMar 22, 2022
Member
nicolas-grekas commentedMar 22, 2022
Thank you@gndk |
nicolas-grekas added a commit that referenced this pull requestMar 22, 2022
…and (gndk)This PR was merged into the 5.4 branch.Discussion----------[FrameworkBundle] Fix exit codes in debug:translation command| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -I noticed this bug while working on a CI job to check translations with `debug:translation --only-missing`. The output of the command was empty (no results in the table), so there were no missing messages. But the command still failed with non-zero exit code.After a bit of investigation I noticed that there were no **missing** messages, but a few **unused** messages. And the command failed with the exit code for **unused** messages, despite running it with `--only-missing`. After confirming this as the problem, the fix was pretty straightforward.The `--only-missing` and `--only-unused` options should be independent of each other.When using the `--only-missing` option, only **missing** messages should be relevant to the outcome of the execution. If there are no missing messages, but some unused messages, the execution of the command was still successful and no non-zero exit code should be returned.The same applies when using the `--only-unused` option. In this case, only **unused** messages should be relevant to the execution result, even if there are some missing messages.Commits-------5439bf2 [FrameworkBundle] Fix exit codes in debug:translation command
Contributor
magikid commentedMay 16, 2022
This resolves#44907 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I noticed this bug while working on a CI job to check translations with
debug:translation --only-missing. The output of the command was empty (no results in the table), so there were no missing messages. But the command still failed with non-zero exit code.After a bit of investigation I noticed that there were nomissing messages, but a fewunused messages. And the command failed with the exit code forunused messages, despite running it with
--only-missing. After confirming this as the problem, the fix was pretty straightforward.The
--only-missingand--only-unusedoptions should be independent of each other.When using the
--only-missingoption, onlymissing messages should be relevant to the outcome of the execution. If there are no missing messages, but some unused messages, the execution of the command was still successful and no non-zero exit code should be returned.The same applies when using the
--only-unusedoption. In this case, onlyunused messages should be relevant to the execution result, even if there are some missing messages.