Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[RateLimiter] Fix rate serialization for long intervals (monthly and yearly)#45764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
smelesh wants to merge0 commits intosymfony:5.4fromsmelesh:fix-rate-serialization

Conversation

@smelesh
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix #...
LicenseMIT
Doc PRno

Long rate intervals (monthly and yearly) are serialized with incorrect ISO interval, so token bucket refills earlier than expected:

  • yearly interval acts as 100 days;
  • monthly interval acts as 10 days.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

I think@alexandre-daubois has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@fabpot
Copy link
Member

Thank you@smelesh.

fabpot added a commit that referenced this pull requestMar 18, 2022
…onthly and yearly) (smelesh)This PR was squashed before being merged into the 5.4 branch.Discussion----------[RateLimiter] Fix rate serialization for long intervals (monthly and yearly)| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | Fix #...| License       | MIT| Doc PR        | noLong rate intervals (monthly and yearly) are serialized with incorrect ISO interval, so token bucket refills earlier than expected:- yearly interval acts as 100 days;- monthly interval acts as 10 days.Commits-------4810066 [RateLimiter] Fix rate serialization for long intervals (monthly and yearly)
@fabpotfabpot closed thisMar 18, 2022
@fabpotfabpotforce-pushed thefix-rate-serialization branch froma34cdba to4810066CompareMarch 18, 2022 06:45
This was referencedApr 2, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@smelesh@carsonbot@fabpot@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp