NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[ErrorHandler][HttpKernel] Read SYMFONY_IDE to render exception in case of fatal error#45745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

GromNaN merged 1 commit intosymfony:6.1fromGromNaN:symfony-ide-fatal

Mar 17, 2022

Merged

[ErrorHandler][HttpKernel] Read SYMFONY_IDE to render exception in case of fatal error#45745

GromNaN merged 1 commit intosymfony:6.1fromGromNaN:symfony-ide-fatal

Mar 17, 2022

Conversation

Copy link

Member

GromNaN commentedMar 15, 2022•
edited
Loading

Q	A
Branch?	6.1
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

In#44575, the env varSYMFONY_IDE is read whenframework.ide is not set. This works to format links in most runtime exceptions. But fatal errors that occurs before application boot are not rendered using this config (ex: syntax error in service class).

Since the env var is globally available, it can be read even if it's not been injected.
The list of IDE formats have been duplicated fromFileLinkFormatter.

The update ofSymfony\Component\HttpKernel\Debug\FileLinkFormatter is not necessary for my use-case, but for exhaustivity.

GromNaN added HttpKernel ErrorHandler labels

Mar 15, 2022

GromNaN requested a review fromyceruto as acode owner

March 15, 2022 12:03

carsonbot added Status: Needs Review Feature labels

Mar 15, 2022

carsonbot added this to the6.1 milestone

Mar 15, 2022

carsonbot changed the title~~[ErrorHandler] Read SYMFONY_IDE to render exception in case of fatal error~~[ErrorHandler][HttpKernel] Read SYMFONY_IDE to render exception in case of fatal error

Mar 15, 2022

GromNaN force-pushed thesymfony-ide-fatal branch from04dc168 tocc4a16dCompare

March 15, 2022 12:08

Copy link

carsonbot commentedMar 16, 2022

Hey!

I think@PhilETaylor has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

nicolas-grekas reviewed

Mar 17, 2022

View reviewed changes

src/Symfony/Component/ErrorHandler/CHANGELOG.md OutdatedShow resolvedHide resolved

nicolas-grekas reviewed

Mar 17, 2022

View reviewed changes

src/Symfony/Component/ErrorHandler/ErrorRenderer/HtmlErrorRenderer.php OutdatedShow resolvedHide resolved

src/Symfony/Component/HttpKernel/Debug/FileLinkFormatter.php OutdatedShow resolvedHide resolved

GromNaN force-pushed thesymfony-ide-fatal branch fromcc4a16d tob0211f5Compare

March 17, 2022 16:43

nicolas-grekas approved these changes

Mar 17, 2022

View reviewed changes

src/Symfony/Component/ErrorHandler/ErrorRenderer/HtmlErrorRenderer.php OutdatedShow resolvedHide resolved

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Mar 17, 2022

GromNaN force-pushed thesymfony-ide-fatal branch 2 times, most recently from97a24e1 toc942cfeCompare

March 17, 2022 17:04

nicolas-grekas reviewed

Mar 17, 2022

View reviewed changes

src/Symfony/Component/ErrorHandler/ErrorRenderer/HtmlErrorRenderer.php OutdatedShow resolvedHide resolved

Read SYMFONY_IDE to render exception in case of fatal error

03ad4af

GromNaN force-pushed thesymfony-ide-fatal branch fromc942cfe to03ad4afCompare

March 17, 2022 18:40

Copy link

Contributor

PhilETaylor commentedMar 17, 2022

I think@PhilETaylor has recently worked with this code. Maybe they can help review this?

Sorry, nothing to add here. My changes were in HtmlRenderer to render a custom template 2 years ago6e1d16b and not related to framework.ide :) :) Although I use the framework.ide links daily so happy to test this PR.