NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Mailer] fix: stringify from address for ses+api transport#45691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.4fromeveryx:6.0

Mar 14, 2022

Merged

[Mailer] fix: stringify from address for ses+api transport#45691

fabpot merged 1 commit intosymfony:5.4fromeveryx:6.0

Mar 14, 2022

Conversation

Copy link

Contributor

everyx commentedMar 10, 2022

close:#45660

Q	A
Branch?	6.0 for bug fixes
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#45660
License	MIT
Doc PR

There are non-ASCII characters in the email address—The email address string must be 7-bit ASCII. If you want to send to or from email addresses that contain Unicode characters in the domain part of an address, you must encode the domain using Punycode. Punycode is not permitted in the local part of the email address (the part before the @ sign) nor in the "friendly from" name. If you want to use Unicode characters in the "friendly from" name, you must encode the "friendly from" name using MIME encoded-word syntax, as described inSending raw email using the Amazon SES API. For more information about Punycode, seeRFC 3492.

- fromAmazon SES email sending errors

We have already stringify to addresses, and we should also stringify the from address.

carsonbot added Status: Needs Review Bug labels

Mar 10, 2022

carsonbot added this to the6.0 milestone

Mar 10, 2022

Copy link

carsonbot commentedMar 10, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot