Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix Mailgun header format for Reply-To#45630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
loduis wants to merge1 commit intosymfony:5.4fromloduis:5.4
Closed

Conversation

@loduis
Copy link

In this moment is sent in lower case so: h:reply-to
You can see the article is h:Reply-To
https://help.mailgun.com/hc/en-us/articles/4401814149147-Adding-A-Reply-To-Address

QA
Branch?5.4 for features / 4.4, 5.4 or 6.0 for bug fixes
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix #...
LicenseMIT
Doc PRsymfony/symfony-docs#...

In this moment is sent in lower case so: h:reply-toYou can see the article is h:Reply-Tohttps://help.mailgun.com/hc/en-us/articles/4401814149147-Adding-A-Reply-To-Address
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@fabpot
Copy link
Member

Headers are not case sensitive. Are you sure it makes a difference?

@loduis
Copy link
Author

Some mail clients are reply to our from addressno-reply after upgrading tosymfony mailer and when I check my old mail sent withmailgun-php the only thing different that I find is that, but I would have to review in more depth the behavior of mailgum-php and the handling of the reply-to header

Before:
image
After:
image

@OskarStarkOskarStark changed the titleFix mailgum header format for Reply-ToFix Mailgun header format for Reply-ToMar 4, 2022
@nicolas-grekas
Copy link
Member

Closing in favor of#45816
Thanks for letting us know about the issue!

fabpot added a commit that referenced this pull requestMar 22, 2022
This PR was merged into the 4.4 branch.Discussion----------[Mailer] Preserve case of headers| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |#45630| License       | MIT| Doc PR        | -Commits-------a64c6e6 [Mailer] Preserve case of headers
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@loduis@carsonbot@fabpot@nicolas-grekas

[8]ページ先頭

©2009-2025 Movatter.jp