Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Fix resetting container between tests#45595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromnicolas-grekas:fwb-reset-test-containerMar 1, 2022
Merged
[FrameworkBundle] Fix resetting container between tests#45595
nicolas-grekas merged 1 commit intosymfony:4.4fromnicolas-grekas:fwb-reset-test-containerMar 1, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedMar 1, 2022
kbond approved these changesMar 1, 2022
Member
kbond left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I confirmed the memory leak from#40965 is still fixed.
87c4591 to4453bdbCompare This was referencedMar 5, 2022
Merged
Merged
Merged
kbond added a commit to kbond/foundry that referenced this pull requestMar 7, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces#45479 and#45581, related to#34078.
Calling
boot()on an already booted kernel does reset the container, so we don't need to care anymore about the state of kernel.#45580 is fixed by removing
private static $kernelContainer, which can be out of sync withstatic::$kernel->getContainer()sinceKernelBrowsercreates new containers when shutting down the kernel between requests.