NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpKernel] fix using Target attribute with controller arguments#45572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromkbond:controller-target-param

Mar 7, 2022

Merged

[HttpKernel] fix using Target attribute with controller arguments#45572

nicolas-grekas merged 1 commit intosymfony:5.4fromkbond:controller-target-param

Mar 7, 2022

Conversation

Copy link

Member

kbond commentedFeb 27, 2022•
edited
Loading

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#45021
License	MIT
Doc PR	n/a

This was supposed tofix#45021 but after adding what I suspected was a failing test, it works as expected. I guess I'm not testing the correct thing?

Here's a quick reproducer that shows the problem in a "real app":

class HomepageControllerextends AbstractController{publicfunction__construct(#[Target('request.logger')]privateLoggerInterface$logger)    {    }    #[Route('/', name:'app_homepage')]publicfunctionindex(#[Target('request.logger')]LoggerInterface$logger):Response    {dd($this->logger->getName(),// "request" (expected)$logger->getName()// "app" (not-expected)        );// ...    }}

carsonbot added Status: Needs Review Feature HttpKernel labels

Feb 27, 2022

carsonbot added this to the6.1 milestone

Feb 27, 2022

kbond force-pushed thecontroller-target-param branch from38d4546 to9c74235Compare

February 27, 2022 14:42

Copy link

Member

nicolas-grekas commentedMar 6, 2022•
edited
Loading

The issue happens where there are no bindings, but only a named autowiring alias.
This "else" block should look for aTarget attribute:

symfony/src/Symfony/Component/HttpKernel/DependencyInjection/RegisterControllerArgumentLocatorsPass.php

Lines 193 to 196 inca27974

	}else {
	$target =ltrim($target,'\\');
	$args[$p->name] =$type ?newTypedReference($target,$type,$invalidBehavior,$p->name) :newReference($target,$invalidBehavior);
	}