Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix table header seperator wrapping#45565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
86c31d2 to9ee4440Comparecarsonbot commentedFeb 27, 2022
Hey! I think@a1812 has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
ContributorAuthor
alamirault commentedApr 5, 2022
Any feedback on this PR will be appreciated. Thanks |
chalasr requested changesApr 7, 2022
Member
chalasr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me, just some minor comments.
I think the bug exists on 4.4 as well, can you confirm and rebase if it's the case?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
9ee4440 toebf38b1Comparefabpot approved these changesApr 9, 2022
Member
fabpot commentedApr 9, 2022
Thank you@alamirault. |
This was referencedApr 27, 2022
Merged
Merged
Merged
GromNaN added a commit to GromNaN/symfony that referenced this pull requestMay 9, 2022
nicolas-grekas added a commit that referenced this pull requestMay 10, 2022
This PR was merged into the 4.4 branch.Discussion----------[Console] Fix CS in Table class after#45565| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | n/a| License | MIT| Doc PR | n/aIndentation issue introduced by [#45565](https://github.com/symfony/symfony/pull/45565/files#diff-879e34698fd4acc2bbbb1e2c9ca2f0daf8f499a1123e4c0fc58dc68895724a91R760-R764)Commits-------d3d72ae Fix CS in Console Table after#45565
nicolas-grekas added a commit that referenced this pull requestMay 10, 2022
* 4.4: [Serializer] Fix AbstractObjectNormalizer not considering pseudo type false [Serializer] Fix JsonSerializableNormalizer ignores circular reference handler in $context [Serializer][PropertyInfo] Fix support for "false" built-in type on PHP 8.2 Fix CS in Console Table after#45565 fix italian translation for validators
nicolas-grekas added a commit that referenced this pull requestMay 10, 2022
* 5.4: [Serializer] Fix AbstractObjectNormalizer not considering pseudo type false [Serializer] Fix JsonSerializableNormalizer ignores circular reference handler in $context [Serializer][PropertyInfo] Fix support for "false" built-in type on PHP 8.2 [ErrorHandler] Fix list of tentative return types Fix CS in Console Table after#45565 Suppress unhandled error in some specific use-cases. fix italian translation for validators
nicolas-grekas added a commit that referenced this pull requestMay 10, 2022
* 6.0: [Serializer] Fix AbstractObjectNormalizer not considering pseudo type false [Serializer] Fix JsonSerializableNormalizer ignores circular reference handler in $context [Serializer][PropertyInfo] Fix support for "false" built-in type on PHP 8.2 [ErrorHandler] Fix list of tentative return types Fix CS in Console Table after#45565 Suppress unhandled error in some specific use-cases. fix italian translation for validators
PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this pull requestSep 6, 2023
* 5.4: [Serializer] Fix AbstractObjectNormalizer not considering pseudo type false [Serializer] Fix JsonSerializableNormalizer ignores circular reference handler in $context [Serializer][PropertyInfo] Fix support for "false" built-in type on PHP 8.2 [ErrorHandler] Fix list of tentative return types Fix CS in Console Table aftersymfony#45565 Suppress unhandled error in some specific use-cases. fix italian translation for validators
PhilETaylor pushed a commit to PhilETaylor/symfony that referenced this pull requestSep 6, 2023
* 6.0: [Serializer] Fix AbstractObjectNormalizer not considering pseudo type false [Serializer] Fix JsonSerializableNormalizer ignores circular reference handler in $context [Serializer][PropertyInfo] Fix support for "false" built-in type on PHP 8.2 [ErrorHandler] Fix list of tentative return types Fix CS in Console Table aftersymfony#45565 Suppress unhandled error in some specific use-cases. fix italian translation for validators
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Before PR, a new seperator is added foreach split line in header
Before PR:
After PR
(Fabbot cannot be green (break unit tests))