Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[symfony/mailjet-mailer] Fix invalid mailjet error managment#45564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:5.4fromalamirault:fix-45420-invalid-mailjet-error-managmentMar 12, 2022
Merged
[symfony/mailjet-mailer] Fix invalid mailjet error managment#45564
fabpot merged 1 commit intosymfony:5.4fromalamirault:fix-45420-invalid-mailjet-error-managmentMar 12, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
carsonbot commentedFeb 27, 2022
Hey! I think@tcheymol has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
src/Symfony/Component/Mailer/Bridge/Mailjet/Tests/Transport/MailjetApiTransportTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Mailer/Bridge/Mailjet/Tests/Transport/MailjetApiTransportTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Mailer/Bridge/Mailjet/Tests/Transport/MailjetApiTransportTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
5c0095a toe83abc2Comparefancyweb approved these changesMar 10, 2022
fabpot approved these changesMar 12, 2022
e83abc2 toaa1e12cCompareMember
fabpot commentedMar 12, 2022
Thank you@alamirault. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When mailjet API status code is not 200, responseis structured (see-below) and is not currently well managed.
Example of bad request response:
{"Messages": [ {"Status":"error","Errors": [ {"ErrorIdentifier":"8e28ac9c-1fd7-41ad-825f-1d60bc459189","ErrorCode":"mj-0005","StatusCode":400,"ErrorMessage":"The To is mandatory but missing from the input","ErrorRelatedTo": ["To"] } ] } ]}This PR fix
Undefined index: Messageand add unit tests.