Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Deprecate requiring the "symfony/symfony" package#45563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedFeb 26, 2022
| Q | A |
|---|---|
| Branch? | 6.1 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | yes |
| Tickets | - |
| License | MIT |
| Doc PR | - |
| { | ||
| $loader =newPhpFileLoader($container,newFileLocator(\dirname(__DIR__).'/Resources/config')); | ||
| if (class_exists(InstalledVersions::class) && InstalledVersions::isInstalled('symfony/symfony') &&'symfony/symfony' !== (InstalledVersions::getRootPackage()['name'] ??'')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why not useclass_exists(FullStack::class)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Because we want to not trigger the deprecation when testing Symfony itself so we anyway have to use the Composer API.
ro0NL commentedFeb 27, 2022
are we ready for it now? |
nicolas-grekas commentedFeb 27, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
No we're not ready to mark the package as abandoned. I don't think doing so would be a good idea actually as it might confuse ppl a lot. |
fabpot commentedMar 4, 2022
Thank you@nicolas-grekas. |