NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.7k

[Runtime] Allow JSON for APP_RUNTIME_OPTIONS#45535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

ro0NL wants to merge2 commits intosymfony:6.1fromro0NL:patch-1

Closed

[Runtime] Allow JSON for APP_RUNTIME_OPTIONS#45535

ro0NL wants to merge2 commits intosymfony:6.1fromro0NL:patch-1

Conversation

Copy link

Contributor

ro0NL commentedFeb 23, 2022•
edited by nicolas-grekas
Loading

Q	A
Branch?	6.1
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

So we can exportAPP_RUNTIME_OPTIONS='{"disable_dotenv":true}' in prod

[Runtime] Allow JSON for APP_RUNTIME_OPTIONS

8e72d8b

carsonbot added Status: Needs Review Bug Runtime labels

Feb 23, 2022

carsonbot added this to the5.4 milestone

Feb 23, 2022

Copy link

Member

nicolas-grekas commentedFeb 24, 2022•
edited
Loading

This is not a bugfix ;)
~~What about making SymfonyRuntime's constructor accept array|json-string instead?~~

nicolas-grekas modified the milestones:5.4,6.1

Feb 24, 2022

nicolas-grekas changed the base branch from5.4 to6.1

February 24, 2022 09:42

nicolas-grekas reviewed

Feb 24, 2022

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What about making SymfonyRuntime's constructor accept array|json-string instead?

Not a good idea as that would prevent merging with options generated by the plugin!

src/Symfony/Component/Runtime/Internal/autoload_runtime.template OutdatedShow resolvedHide resolved

Copy link

ContributorAuthor

ro0NL commentedFeb 24, 2022•
edited
Loading

This is not a bugfix ;)

Are you saying APP_RUNTIME_OPTIONS is not a supported env var? but more like some internal global var?

IMHO it looks like an env var extension point ... thus should support string values actually. Thus a bugfix :)

Or how could i set an PHP array using env var?

We're not at 6.1 yet, so as a feature i will postpone this PR. And we patch the front controller manually for the time being (maybe forever), if that's the intended feature-usage currently.

Copy link

ContributorAuthor

ro0NL commentedFeb 24, 2022

So, tbe bugfix would be

$ APP_RUNTIME_OPTIONS={} bin/console PHP Warning:  A non-numeric value encountered in vendor/autoload_runtime.php on line 23PHP Fatal error:  Uncaught Error: Unsupported operand types in vendor/autoload_runtime.php:23