Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix deprecations on PHP 8.2#45532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedFeb 23, 2022
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | On the road to#44282 |
| License | MIT |
| Doc PR | - |
b169934 to048307fComparenicolas-grekas commentedFeb 25, 2022
Code is now 100% deprecation-free on PHP 8.2. |
| new \DatePeriod('R4/2012-07-01T00:00:00Z/P7D'), | ||
| ]]; | ||
| $value = \PHP_VERSION_ID >=70406 ?newArrayObject() :new \ArrayObject(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm curious, what's the reason for this version check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
PHP 8.2 needs the attribute for this test but I also want to keep a test that creates a native ArrayObject.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh, I see. That version number 7.4.6 seemed so oddly specific that I though I had missed something in PHP's ChangeLog. 😅