Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Lock] Release Locks from Internal Store on Postgres waitAndSave*#45526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@chrisguitarguy
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#45505
LicenseMIT
Doc PRn/a

if something goes wrong talking with the database connection (like a
disconnect or timeout) the parentLock object will catch and simply
say that there was an error acquring the lock. However, waitAndSave and
waitAndSaveRead both store the lock in an internal store so trying to
re-acquire the lock with the same connection would result in a lock
confliected exception even though the lock was never acquired in the
first place.

This takes the fix from#44828
and applies it to the waitAndSave and waitAndSaveRead methods on both
DoctrineDbalPostgreSqlStore and PostgreSqlStore.

@carsonbotcarsonbot added this to the5.4 milestoneFeb 23, 2022
@chrisguitarguychrisguitarguy changed the titleRelease Locks from Internal Store on Postgres waitAndSave*[Lock] Release Locks from Internal Store on Postgres waitAndSave*Feb 23, 2022
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM thanks! I just have two minors CS notes.

chrisguitarguy reacted with thumbs up emojichrisguitarguy reacted with heart emoji
@carsonbotcarsonbot changed the title[Lock] Release Locks from Internal Store on Postgres waitAndSave*Release Locks from Internal Store on Postgres waitAndSave*Feb 23, 2022
@chrisguitarguy
Copy link
ContributorAuthor

Do I need to worry about that 8.1 low-deps check? Looks like something in the form component failed a git checkout?

@nicolas-grekas
Copy link
Member

No need to.

@carsonbotcarsonbot changed the titleRelease Locks from Internal Store on Postgres waitAndSave*[Lock] Release Locks from Internal Store on Postgres waitAndSave*Feb 23, 2022
@nicolas-grekas
Copy link
Member

Thank you@chrisguitarguy.

@nicolas-grekasnicolas-grekas merged commit87a1a34 intosymfony:5.4Feb 24, 2022
This was referencedFeb 28, 2022
@chrisguitarguychrisguitarguy deleted the chrisguitarguy/45505 branchFebruary 28, 2022 16:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@jderussejderusseAwaiting requested review from jderussejderusse is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@chrisguitarguy@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp