Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Lock] Release Locks from Internal Store on Postgres waitAndSave*#45526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
4718037 to87fbb34Compare
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM thanks! I just have two minors CS notes.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
chrisguitarguy commentedFeb 23, 2022
Do I need to worry about that 8.1 low-deps check? Looks like something in the form component failed a git checkout? |
nicolas-grekas commentedFeb 23, 2022
No need to. |
3221732 to32a0f50Comparenicolas-grekas commentedFeb 24, 2022
Thank you@chrisguitarguy. |
if something goes wrong talking with the database connection (like a
disconnect or timeout) the parent
Lockobject will catch and simplysay that there was an error acquring the lock. However, waitAndSave and
waitAndSaveRead both store the lock in an internal store so trying to
re-acquire the lock with the same connection would result in a lock
confliected exception even though the lock was never acquired in the
first place.
This takes the fix from#44828
and applies it to the waitAndSave and waitAndSaveRead methods on both
DoctrineDbalPostgreSqlStore and PostgreSqlStore.