Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Intl] fix wrong offset timezone PHP 8.1#45460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedFeb 17, 2022
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
nicolas-grekas left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I pushed some changes, but I cannot reproduce the failure on my local setup.
When I revert the change, the new test case still passes. Can you confirm that's not the case for you?
Lenny4 commentedFeb 17, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@nicolas-grekas |
nicolas-grekas commentedFeb 17, 2022
With both PHP 8.1 and 7.4 |
nicolas-grekas commentedFeb 17, 2022
I ran the test case with |
Lenny4 commentedFeb 17, 2022
This is really strange I got the same result as you. |
ro0NL commentedFeb 17, 2022
for me the patch works |
nicolas-grekas commentedFeb 17, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@ro0NL the issue is not that tests are red, it's that they are always green, even when using PHP 8.1 BEFORE THE PATCH. |
ro0NL left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
PHP 8.1 docker images uses:"Olson" Timezone Database Version => 2021.5
and the test is red without this patch 👍
nicolas-grekas commentedFeb 18, 2022
Thank you@Lenny4. |
Uh oh!
There was an error while loading.Please reload this page.