Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Runtime] Fix dotenv_overload with commands#45426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromfancyweb:runtime/fix-overload-cmd-no-optsFeb 15, 2022
Merged
[Runtime] Fix dotenv_overload with commands#45426
nicolas-grekas merged 1 commit intosymfony:5.4fromfancyweb:runtime/fix-overload-cmd-no-optsFeb 15, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
f4266f9 tof9de6bcComparef9de6bc to4075269Comparenicolas-grekas approved these changesFeb 15, 2022
Member
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(I made some tweaks)
Member
nicolas-grekas commentedFeb 15, 2022
Thank you@fancyweb. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bugs introduced in#44997.
For example, if
$_SERVER['APP_ENV'] = 'foo';exists and withAPP_ENV=prodin.env, any command will throwCannot use "--env" or "-e" when the...becausefoois considered as the input env.Determining the input env and debug from
$_SERVERis wrong because when the--no-debugand--envare not used, we actually consider the existing env and debug as the input end and debug. We need to know and use the real input env and debug.