NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Serializer] Ensuring end of line character apply with constructor settings in CSV encoder#45391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4frombizley:patch-1

Feb 11, 2022

Merged

[Serializer] Ensuring end of line character apply with constructor settings in CSV encoder#45391

nicolas-grekas merged 1 commit intosymfony:5.4frombizley:patch-1

Feb 11, 2022

Conversation

Copy link

bizley commentedFeb 10, 2022

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets
License	MIT
Doc PR

While providing END_OF_LINE different than\n through constructor, context value was still used which ended in error if not present in context.

bizley requested a review fromdunglas as acode owner

February 10, 2022 17:20

carsonbot added Status: Needs Review Bug Serializer labels

Feb 10, 2022

carsonbot added this to the5.4 milestone

Feb 10, 2022

Copy link

carsonbot commentedFeb 10, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot