There's a coding style violation that wants me to add a trailing comma in the regex array. AFAIK that is only supported on PHP 7.3+, so it'll probably cause CI to fail. Should I still do it?

also, what is your policy with implementing review comments, should I make new commits or squash immediately?

implemented review comments (except for the trailing comma one, see above)

There's a coding style violation that wants me to add a trailing comma in the regex array. AFAIK that is only supported on PHP 7.3+, so it'll probably cause CI to fail. Should I still do it?

Trailing commas in array constructors are allowed in PHP 7.1 already, no worries.

also, what is your policy with implementing review comments, should I make new commits or squash immediately?

As you wish, we can squash while merging.

alright, thx. All suggestions should be implemented now

I'm merging it in 6.1 as this is a new feature (this was not supported before).

well, it worked with Swiftmailer, so from the point of view of the user it's still a regression

Thank you@flack.

We've been more and more strict about what we consider a bug. Stability is the most important thing for already released versions.

Yeah, makes sense I guess. Unfortunately, for me it means I have to continue using the abandoned Switfmailer package (with composer shouting at me every time I update something) until I can migrate to php 8+ and sf 6

Hi.
Can I please for merge this for LTS version too?