Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Log section minor fixes (missing "notice" filter, log priority, accessibility)#45351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
fabpot commentedFeb 25, 2022
javiereguiluz approved these changesFeb 25, 2022
Member
javiereguiluz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These fixes are very nice! Thanks Jiří
Member
fabpot commentedFeb 25, 2022
Thank you@Amunak. |
fabpot added a commit that referenced this pull requestFeb 25, 2022
…ce" filter, log priority, accessibility) (Amunak)This PR was squashed before being merged into the 5.4 branch.Discussion----------[WebProfilerBundle] Log section minor fixes (missing "notice" filter, log priority, accessibility)| Q | A| ------------- | ---| Branch? | 5.4 <!-- see below -->| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |#42195 (related)| License | MIT| Doc PR | ~This fixes minor front-end issues with the redesigned Log section in WebProfilerBundle.Marking as bugfix, since technically the redesign removed some features without documenting it - the log level is now visible even for low level logs (debug, notice, info). I have also added the missing "notice" filter and made sure that when a filter is missing the message is shown (fail-safe).I have also implemented accessibility fixes mentioned in the original PR (#42195) by@stof.I did not add tests because I have no idea where or how - currently the profiler front-end is not tested (or at least the log section). These changes do not affect the logic behind the panel in a way that could be easily tested.Screenshot of the changes: notice the visible log levels and added "notice" filter:Commits-------1c3b266 [WebProfilerBundle] Log section minor fixes (missing "notice" filter, log priority, accessibility)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes minor front-end issues with the redesigned Log section in WebProfilerBundle.
Marking as bugfix, since technically the redesign removed some features without documenting it - the log level is now visible even for low level logs (debug, notice, info). I have also added the missing "notice" filter and made sure that when a filter is missing the message is shown (fail-safe).
I have also implemented accessibility fixes mentioned in the original PR (#42195) by@stof.
I did not add tests because I have no idea where or how - currently the profiler front-end is not tested (or at least the log section). These changes do not affect the logic behind the panel in a way that could be easily tested.
Screenshot of the changes: notice the visible log levels and added "notice" filter: