NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Mailer] Fix string-cast of exceptions thrown by authenticator in EsmtpTransport#45338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:4.4fromwikando-ck:issue_45308

Feb 8, 2022

Merged

[Mailer] Fix string-cast of exceptions thrown by authenticator in EsmtpTransport#45338

fabpot merged 1 commit intosymfony:4.4fromwikando-ck:issue_45308

Feb 8, 2022

Conversation

Copy link

Contributor

wikando-ck commentedFeb 7, 2022

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#45308
License	MIT

Replace an exception that was being cast to string with a call togetMessage().
This prevents information about the system leaking into the exception, (files/directories, stack trace).

Additionally (seehttps://symfony.com/releases):

I wasn't able to inject mocked authenticators, as they are instantiated in the constructor.
This makes unit testing very hard.
I was able to reproduce the problem with this test, but it will hit a real smtp server and should not be added to a testsuite.

// EsmtpTransportTest.phppublicfunctiontestAuthExceptionContainsNoStackTrace()    {$transport =newEsmtpTransport('smtp.ionos.de',465,true);$transport->setUsername("test");$transport->setPassword("test");$message =newMessage();$message->setHeaders(newHeaders(newMailboxListHeader("From", [Address::create('test@gmail.com')]),newMailboxListHeader("To", [Address::create('test@gmail.com')]))        );try {$transport->send($message);$this->fail("Expected TransportException");        }catch (TransportExceptionInterface$e) {$this->assertStringNotContainsString("Stack trace:",$e->getMessage());$this->assertStringNotContainsString('Symfony\Component\Mailer\Transport\Smtp',$e->getMessage());        }    }

carsonbot added Status: Needs Review Bug Mailer labels

Feb 7, 2022

carsonbot added this to the4.4 milestone

Feb 7, 2022

Copy link

carsonbot commentedFeb 7, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot