Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] Mention parameter type in phpdoc explicitly#45324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
andrew-demb commentedFeb 5, 2022
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
nicolas-grekas commentedFeb 7, 2022
The type is optional, so that this should not be required. If you're using a parser that mandates the type, you might want to open an issue there. |
andrew-demb commentedFeb 7, 2022
Yes, the type is optional. So I don't know a reason to not specify it. |
nicolas-grekas commentedFeb 8, 2022
I would say that the Symfony code-style is to not duplicate into phpdoc info that is already found in the signature. |