Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Cache] Mention parameter type in phpdoc explicitly#45324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
andrew-demb wants to merge1 commit intosymfony:4.4fromandrew-demb:patch-2

Conversation

@andrew-demb
Copy link
Contributor

QA
Branch?4.4
Bug fix?no
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

@andrew-dembandrew-demb changed the titleMention parameter type in phpdoc explicitly[Cache] Mention parameter type in phpdoc explicitlyFeb 5, 2022
@derrabusderrabus added this to the4.4 milestoneFeb 5, 2022
@nicolas-grekas
Copy link
Member

The type is optional, so that this should not be required.
Seehttps://docs.phpdoc.org/3.0/guide/references/phpdoc/tags/param.html

If you're using a parser that mandates the type, you might want to open an issue there.

@andrew-demb
Copy link
ContributorAuthor

Yes, the type is optional.
But omitting type is not consistent with Symfony codebase.

So I don't know a reason to not specify it.

@nicolas-grekas
Copy link
Member

I would say that the Symfony code-style is to not duplicate into phpdoc info that is already found in the signature.
We cleaned up a lot of phpdoc thanks to php8 on branches >= 5.4.
I'm closing therefore, thanks for submitting.

@andrew-dembandrew-demb deleted the patch-2 branchFebruary 8, 2022 10:55
@wouterjwouterj mentioned this pull requestJan 3, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@andrew-demb@nicolas-grekas@derrabus@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp