Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Fix ignored callbacks in denormalization#45323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4frombenjaminmal:ticket_43563
Feb 11, 2022
Merged

[Serializer] Fix ignored callbacks in denormalization#45323

nicolas-grekas merged 1 commit intosymfony:4.4frombenjaminmal:ticket_43563
Feb 11, 2022

Conversation

@benjaminmal
Copy link

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#43563-2
LicenseMIT
Doc PR-

Stop ignoring callbacks in denormalization. #freeTheCallbacks!!!

@carsonbot
Copy link

Hey!

I think@Th3Mouk has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

Copy link
Member

@dunglasdunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm in favor of deprecating the callbacks and recommending using custom normalizers instead and I would revert the changes made to the PHPDoc for consistency, otherwise +1.

@nicolas-grekas
Copy link
Member

Thank you@benjaminmal.

@nicolas-grekasnicolas-grekas merged commit7fd9127 intosymfony:4.4Feb 11, 2022
@nicolas-grekas
Copy link
Member

I just found that this is already deprecated and removed from 5.4.

@nicolas-grekas
Copy link
Member

Hum, onlysetCallbacks() is deprecated, my bad.

@benjaminmalbenjaminmal deleted the ticket_43563 branchFebruary 11, 2022 16:19
This was referencedFeb 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@dunglasdunglasdunglas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@benjaminmal@carsonbot@nicolas-grekas@dunglas
[8]ページ先頭
©2009-2025 Movatter.jp