Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpKernel][WebProfilerBundle] Fixed error count by log not displayed in WebProfilerBundle#45302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromSVillette:fix_45183
Feb 4, 2022

Conversation

@SVillette
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#45183
LicenseMIT
Doc PR-

This PR is the following of#45198. Refer to this PR for details.

image

UlrichHP reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've just checked this change in a real Symfony app, and it worked for me 👍

Thanks@SVillette!

SVillette reacted with thumbs up emoji
@SVillette
Copy link
ContributorAuthor

SVillette commentedFeb 4, 2022
edited
Loading

Thanks@javiereguiluz for your review.

I've run the tests on my local forHttpKernel component and it's all green, any idea whycontinuous-integration/appveyor/pr failed onHttpFoundation ?

@fabpot
Copy link
Member

Thank you@SVillette.

SVillette reacted with heart emoji

@fabpotfabpot merged commit5cb5880 intosymfony:5.4Feb 4, 2022
@SVilletteSVillette deleted the fix_45183 branchFebruary 4, 2022 08:13
This was referencedFeb 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@SVillette@carsonbot@fabpot@javiereguiluz

[8]ページ先頭

©2009-2025 Movatter.jp