When using theAsEventListener on a decorator, it is ignored instead of registering the decorator as an event listener. This is because autoconfigured tags are not applied to decorators since#30417.

EventSubscriberInterface works as expected since#38999, when thekernel.event_subscriber' tag was added to a list of "behavior describing tags" which can be autoconfigured onto decorators.

This PR addskernel.event_listener to this default list of tags, makingAsEventListener work as expected on decorators.

Addedkernel.event_listener to the default list of behavior describ…

5fbb217

…ing tags, fixing AsEventListener attribute not working on decorators.

carsonbot added Status: Needs Review Bug DependencyInjection labels

Feb 3, 2022

carsonbot added this to the5.4 milestone

Feb 3, 2022

Copy link

carsonbot commentedFeb 3, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

LANGERGabrielle changed the title~~[DependencyInjection] Fixed AsEventListener not working on decorators~~[DependencyInjection] Fix AsEventListener not working on decorators

Feb 3, 2022