Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] Support canners in object normalizer#45282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.1fromrmikalkenas:serializer-canners
Apr 27, 2022

Conversation

@rmikalkenas
Copy link
Contributor

QA
Branch?6.1
Bug fix?no
New feature?yes
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Noticed that serializer is not capable of normalizing properties with methods that start withcan prefix, even though property info component has support for it. I think it's inconsistent and serializer should support it as well.
Targeting 6.1 branch as this sounds like a new feature (correct me if wrong). Also not sure about BC as this change might break others code (until this change, properties with can methods were silently skipped from normalization)

Kocal reacted with heart emoji
@carsonbot
Copy link

Hey!

I think@mtarld has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@rmikalkenasrmikalkenasforce-pushed theserializer-canners branch 3 times, most recently fromcfdafae tob88d43cCompareMarch 2, 2022 07:36
@rmikalkenasrmikalkenasforce-pushed theserializer-canners branch 2 times, most recently from61d2e0b to02d6105CompareMarch 14, 2022 13:24
@rmikalkenas
Copy link
ContributorAuthor

It's been hanging for a while, is there any issues with this PR?

Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM for 6.1

@fabpot
Copy link
Member

Thank you@rmikalkenas.

@fabpotfabpot mentioned this pull requestApr 27, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@mtarldmtarldmtarld approved these changes

@chalasrchalasrchalasr approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

@OskarStarkOskarStarkAwaiting requested review from OskarStark

+1 more reviewer

@EmilMasseyEmilMasseyEmilMassey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

8 participants

@rmikalkenas@carsonbot@fabpot@nicolas-grekas@OskarStark@mtarld@chalasr@EmilMassey
[8]ページ先頭
©2009-2025 Movatter.jp