NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpClient] Fix Content-Length header when possible#45261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fancyweb merged 1 commit intosymfony:4.4fromnicolas-grekas:hc-fix-content-length

Feb 1, 2022

Merged

[HttpClient] Fix Content-Length header when possible#45261

fancyweb merged 1 commit intosymfony:4.4fromnicolas-grekas:hc-fix-content-length

Feb 1, 2022

Conversation

Copy link

Member

nicolas-grekas commentedJan 31, 2022

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#45260
License	MIT
Doc PR	-

When userland fails to compute the correct Content-Length header and we can fix it, as is the case in the linked issue.

carsonbot added Status: Needs Review Bug HttpClient labels

Jan 31, 2022

carsonbot added this to the4.4 milestone

Jan 31, 2022

nicolas-grekas force-pushed thehc-fix-content-length branch fromad21dbe toab596c5Compare

January 31, 2022 18:24

ro0NL approved these changes

Jan 31, 2022

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jan 31, 2022

nicolas-grekas force-pushed thehc-fix-content-length branch 3 times, most recently from85a76d6 toc87444dCompare

January 31, 2022 19:03

chalasr approved these changes

Jan 31, 2022

View reviewed changes

fancyweb reviewed

Feb 1, 2022

View reviewed changes

src/Symfony/Component/HttpClient/HttpClientTrait.phpShow resolvedHide resolved

src/Symfony/Component/HttpClient/HttpClientTrait.php OutdatedShow resolvedHide resolved

kaznovac reviewed

Feb 1, 2022

View reviewed changes

src/Symfony/Component/HttpClient/HttpClientTrait.phpShow resolvedHide resolved

[HttpClient] Fix Content-Length header when possible

f5c2e6e

nicolas-grekas force-pushed thehc-fix-content-length branch fromc87444d tof5c2e6eCompare

February 1, 2022 09:13

ro0NL mentioned this pull request

Feb 1, 2022

Let final client decide content-lengthphpro/soap-client#416

Closed

fancyweb approved these changes

Feb 1, 2022

View reviewed changes

Copy link

Contributor

fancyweb commentedFeb 1, 2022

Thank you@nicolas-grekas.

fancyweb merged commit582f572 intosymfony:4.4

Feb 1, 2022

nicolas-grekas deleted the hc-fix-content-length branch

February 1, 2022 09:54

This was referencedFeb 28, 2022

Release v4.4.38#45576

Merged

Release v5.4.5#45577

Merged

Release v6.0.5#45578

Merged

nicolas-grekas mentioned this pull request

Mar 22, 2022

Post with redirected response in HttpClient 5.4.5 throws a 408 error (worked properly on HttpClient 5.4.3)#45709

Closed

nicolas-grekas mentioned this pull request

Jan 12, 2023

[HttpClient] Let curl handle content-length headers#48966

Merged

nicolas-grekas added a commit that referenced this pull request

Jan 13, 2023

bug#48966[HttpClient] Let curl handle content-length headers (nicol…

3c154c7

…as-grekas)This PR was merged into the 5.4 branch.Discussion----------[HttpClient] Let curl handle content-length headers| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#47973,#46499,#46823| License       | MIT| Doc PR        | -I'm not sure why (maybe some older and buggy curl versions?) but it looks like curl might send content-length headers to proxies.This didn't happen before#45261 so I'm trying to use curl in the same was as we did by the time, aka letting it handle content-length header when possible.This is something that I already attempted in#45814 but was partly reverted in#45998. The attached patch is free from such issue.Commits-------5b27dc2 [HttpClient] Let curl handle content-length headers