Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PropertyAccess] Fix handling of uninitialized property of parent class#45255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@filiplikavcan
Copy link
Contributor

@filiplikavcanfiliplikavcan commentedJan 31, 2022•
edited by nicolas-grekas
Loading

QA
Branch?4.4
Bug fix?yes
TicketsFix#45233
New feature?no
Deprecations?no
LicenseMIT

This fix introduced a new bug:

class X{publicint$a;}class Yextends X{}(newY)->a;// PropertyAccessor expects: Typed property Y::$a must not be accessed before initialization// Actual exception message: Typed property X::$a must not be accessed before initialization

This prevents from throwingAccessException exception and it bubbles up and causes this exception after form submit: "Typed property X::$a must not be accessed before initialization" which would otherwise be handled by PropertyPathAccessor:

        }catch (PropertyAccessException$e) {// ...returnnull;        }

@nicolas-grekasnicolas-grekasforce-pushed thefix-unitialized-property-of-parent-class branch frombf24301 to5cd10b0CompareJanuary 31, 2022 15:53
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I pushed a few changes, thanks for the PR.

@nicolas-grekas
Copy link
Member

Thank you@filiplikavcan.

@nicolas-grekasnicolas-grekas merged commitb7da2a0 intosymfony:4.4Jan 31, 2022
This was referencedFeb 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@ycerutoycerutoyceruto approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@filiplikavcan@nicolas-grekas@yceruto@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp