Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Revert StringInput bc break from #45088#45240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedJan 29, 2022
Are you using the constant and the changed value breaks your stuff? What about making the new constant private instead? |
bobthecow commentedJan 29, 2022
PsySH extends StringInput for its ShellInput (which basically adds the ability to have a "code" chunk that gets treated literally). It had to implement its own If you don't want this to be part of the public API, it'd make sense to make the new one private. I don't think anyone else was silly enough to use it, but there are a lot of PsySH versions going back years that depend on the previous public constants so let's at least keep them working :) |
nicolas-grekas commentedJan 30, 2022
Thanks for the PR and the details. I'm fine as is :) |
fancyweb left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is the constant really deprecated though? Just adding a comment won't be enough I guess.
bobthecow commentedJan 30, 2022
Even if it were possible (I'm not sure it is) any more aggressive deprecation than a comment would violate semver. |
fancyweb commentedJan 30, 2022
I mean in 6.1. Either we don't deprecate it at all and we remove that comment or we need a strategy on 6.1 to effectively be able to remove the constant in 7.0. I just don't remember if just adding a |
bobthecow commentedJan 30, 2022
I'm not sure what you normally do, but I found several other comment-only deprecation notes that I modeled this after. |
Uh oh!
There was an error while loading.Please reload this page.
ad6c725 toaab2f2aComparefancyweb commentedJan 31, 2022
Thank you@bobthecow. |
bobthecow commentedJan 31, 2022
Thank you! |
Fix a backwards compatibility break introduced in#45088 and released in v4.4.37, v5.3.14, v5.4.3 and v6.0.3.
I went with
REGEX_UNQUOTED_STRINGby analog to theREGEX_QUOTED_STRINGconstant name, but don't have a strong opinion on what it should be called :)