Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Fixes weird spacing in log message context/trace output#45219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedJan 28, 2022
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| table.logs .log-metadata { | ||
| margin: 8px 0 0; | ||
| } | ||
| table.logs .log-metadata span { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this might need to use> span too, to avoid affecting spans in the nested dump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes indeed, I didn't see any changing behavior before so I left it. But it causes some weird wrapping
the$exists... should start on the same line as the>.
tldr I've added it.
fabpot commentedFeb 2, 2022
Thank you@jennevdmeer. |
This is a fix for a small issue created inbcb3329. Where there is space created in the expanded log message context/trace output as seen below while preserving the space between the log message level, and context and trace toggles.