Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Fix missing arguments when a serialization default context is bound#45193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 0 commits intosymfony:5.4fromArnoudThibaut:fix-44960
Jan 26, 2022

Conversation

@ArnoudThibaut
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#44960
LicenseMIT

I usednull as first argument forJsonSerializableNormalizer definition even if a service exist for theClassMetadataFactoryInterface to keep the actual behavior

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@ArnoudThibautArnoudThibaut changed the base branch from6.1 to5.4January 26, 2022 18:22
@nicolas-grekas
Copy link
Member

/cc@soyuka

Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's the first time the core makes use of bindings I believe, which seems ok.
The fix looks alright 👍

@nicolas-grekasnicolas-grekas modified the milestones:6.1,5.4Jan 26, 2022
@nicolas-grekas
Copy link
Member

Thank you@ArnoudThibaut.

@nicolas-grekasnicolas-grekas merged commit111459e intosymfony:5.4Jan 26, 2022
This was referencedJan 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[Serializer] Globally configured serializer context fails

4 participants

@ArnoudThibaut@carsonbot@nicolas-grekas@chalasr
[8]ページ先頭
©2009-2025 Movatter.jp