Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Notifier] Fix encoding of messages with FreeMobileTransport#45185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.3from94noni:patch-1
Jan 26, 2022

Conversation

@94noni
Copy link
Contributor

@94noni94noni commentedJan 26, 2022
edited by nicolas-grekas
Loading

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix sending accents chars
LicenseMIT

When I firstintroduce this transport I used to test it with basic text, now with some French accent I need this fix otherwise the accent chars are not sent


$response =$this->client->request('POST',$endpoint, [
'json' => [
'query' => [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

can you please try usingbody here instead?
if we keepquery, can we keep POST or do we need GET as a method?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

commented on other discu#45185 (comment)
withquery andPOST it works well

@carsonbotcarsonbot changed the titleUpdate FreeMobileTransport.php[Notifier] Update FreeMobileTransport.phpJan 26, 2022
@nicolas-grekasnicolas-grekas changed the title[Notifier] Update FreeMobileTransport.php[Notifier] Fix encoding of messages with FreeMobileTransportJan 26, 2022
@nicolas-grekasnicolas-grekas modified the milestones:5.4,5.3Jan 26, 2022
@nicolas-grekas
Copy link
Member

Thank you@94noni.

94noni reacted with hooray emoji

@nicolas-grekasnicolas-grekas merged commit4565edb intosymfony:5.3Jan 26, 2022
@94noni94noni deleted the patch-1 branchJanuary 26, 2022 15:40
This was referencedJan 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof left review comments

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@jderussejderusseAwaiting requested review from jderusse

@lyrixxlyrixxAwaiting requested review from lyrixx

@wouterjwouterjAwaiting requested review from wouterj

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

4 participants

@94noni@nicolas-grekas@stof@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp