Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] Fix tests on PHP 7.1#45156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromchalasr:di-test-7.1
Jan 24, 2022

Conversation

@chalasr
Copy link
Member

@chalasrchalasr commentedJan 24, 2022•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Should make Appveyor green. Theobject typehint is 7.2+.

@carsonbotcarsonbot added this to the4.4 milestoneJan 24, 2022
@carsonbotcarsonbot changed the title[DI] Fix tests on PHP 7.1[DependencyInjection] Fix tests on PHP 7.1Jan 24, 2022
@stof
Copy link
Member

Wasn't this precisely meant to test support for usingobject in bindings ? If yes, we should skip the test on PHP 7.1 instead of removing the proper testing.

@chalasr
Copy link
MemberAuthor

chalasr commentedJan 24, 2022•
edited
Loading

Not really, it's meant to cover bindings on inline services (#45063). Still, PR updated to skip the test on PHP<7.2.

@nicolas-grekas
Copy link
Member

Thank you@chalasr.

@nicolas-grekasnicolas-grekas merged commit7eea1cb intosymfony:4.4Jan 24, 2022
@chalasrchalasr deleted the di-test-7.1 branchJanuary 24, 2022 19:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@chalasr@stof@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp