NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[Serializer] Set context annotation as not final#45155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.1frombenjaminmal:not-final-context-annotation

Jan 25, 2022

Merged

[Serializer] Set context annotation as not final#45155

fabpot merged 1 commit intosymfony:6.1frombenjaminmal:not-final-context-annotation

Jan 25, 2022

Conversation

Copy link

benjaminmal commentedJan 24, 2022

Q	A
Branch?	6.1
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	#45106
License	MIT
Doc PR	N/A

Allow extendingContext annotation for creating custom annotations.

This is my first PR for Symfony, don't hesitate to tell if something is wrong with it ;)

benjaminmal requested a review fromdunglas as acode owner

January 24, 2022 14:09

carsonbot added Status: Needs Review Feature Serializer labels

Jan 24, 2022

carsonbot added this to the6.1 milestone

Jan 24, 2022

Copy link

carsonbot commentedJan 24, 2022

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot