Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Ability to customize payload when sending mail through mailjet+api#45152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
gam6itko wants to merge0 commits intosymfony:6.1fromgam6itko:mailjet_api_header1

Conversation

@gam6itko
Copy link
Contributor

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#44100
LicenseMIT
Doc PRsymfony/symfony-docs#...

Make able to set custom properties likeTemplateID via headers.

User can easily switch between smtp and api transport with keeping headers payload

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@gam6itkogam6itko changed the base branch from6.1 to5.4January 24, 2022 13:56
@carsonbot
Copy link

Hey!

I think@tcheymol has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@tcheymol
Copy link
Contributor

Feels good for me, I can't wait to try this 😁

@gam6itkogam6itko changed the base branch from5.4 to6.1February 8, 2022 09:51
@gam6itkogam6itko changed the title[symfony/mailjet-mailer] Ability to customize payload when sending mail through mailjet+api[Mailer] Mailjet. Ability to customize payload when sending mail through mailjet+apiFeb 12, 2022
@nicolas-grekasnicolas-grekas changed the title[Mailer] Mailjet. Ability to customize payload when sending mail through mailjet+api[Mailer] Ability to customize payload when sending mail through mailjet+apiFeb 13, 2022
@carsonbotcarsonbot changed the title[Mailer] Ability to customize payload when sending mail through mailjet+apiAbility to customize payload when sending mail through mailjet+apiFeb 21, 2022
@fabpot
Copy link
Member

Thank you@gam6itko.

fabpot added a commit that referenced this pull requestFeb 25, 2022
… mailjet+api (gam6itko)This PR was squashed before being merged into the 6.1 branch.Discussion----------Ability to customize payload when sending mail through mailjet+api| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       |Fix#44100 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->Make able to set custom properties like `TemplateID` via headers.User can easily switch between smtp and api transport with keeping headers payloadCommits-------9a31686 Ability to customize payload when sending mail through mailjet+api
@fabpotfabpot closed thisFeb 25, 2022
@gam6itkogam6itko deleted the mailjet_api_header1 branchFebruary 25, 2022 08:52
@fabpotfabpot mentioned this pull requestApr 15, 2022
@94noni
Copy link
Contributor

@gam6itko@fabpot is it normal the PR does not contains code?
referenced from the#46049 (also on Symfony-docs repo there is an issue pointing to this)
thank you

@gam6itko
Copy link
ContributorAuthor

@94noni here9a31686

94noni reacted with rocket emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+1 more reviewer

@tcheymoltcheymoltcheymol left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

[symfony/mailjet-mailer] Being able to customize payload when sending mail through mailjet+api

6 participants

@gam6itko@carsonbot@tcheymol@fabpot@94noni@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp