Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Yaml] Making the parser stateless#45140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4frommamazu:4.4
Jan 25, 2022
Merged

[Yaml] Making the parser stateless#45140

fabpot merged 1 commit intosymfony:4.4frommamazu:4.4
Jan 25, 2022

Conversation

@mamazu
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

Currently if you parse multiple files with the sameParser instance, you get different results in the error reporting since the parser doesn't reset the offset.

How to reproduce

If you remove the line added in the parser then the error message shows the incorrect line number and the test will fail.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the titleMaking the parser stateless[Yaml] Making the parser statelessJan 23, 2022
Copy link
Member

@stofstof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking at the properties, the reset is also missing forrefsBeingParsed

@mamazu
Copy link
ContributorAuthor

This is true and on some objects the offset is getting reset back to 0. I haven't really dug into the code of the parser.

@mamazu
Copy link
ContributorAuthor

Should I also add a reset for therefsBeingParsed even though I don't know how to reproduce the error in a test?

@nicolas-grekas
Copy link
Member

Yes please

@fabpot
Copy link
Member

Thank you@mamazu.

@fabpotfabpot merged commit8ba3fa7 intosymfony:4.4Jan 25, 2022
@mamazumamazu deleted the 4.4 branchJanuary 25, 2022 11:04
This was referencedJan 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@fabpotfabpotfabpot approved these changes

@kbondkbondkbond approved these changes

@chalasrchalasrchalasr approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

8 participants

@mamazu@carsonbot@nicolas-grekas@fabpot@kbond@stof@chalasr@derrabus
[8]ページ先頭
©2009-2025 Movatter.jp