Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] fix restoring stty mode on CTRL+C#45109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
nicolas-grekas commentedJan 21, 2022
| Q | A |
|---|---|
| Branch? | 5.3 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix#44045 |
| License | MIT |
| Doc PR | - |
3d9cf4d to2c9718fCompare15a32aa to2bc6cfcComparecarsonbot commentedJan 22, 2022
Hey! I think@ostrolucky has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
Member
chalasr commentedJan 22, 2022
Could this be tested? |
0485358 to7d40d0bCompareMemberAuthor
nicolas-grekas commentedJan 24, 2022
Test added 🥵 |
7d40d0b to3dfcbe0Compare3dfcbe0 tob6db5cbCompareMember
chalasr commentedJan 24, 2022
Thank you@nicolas-grekas. |
Member
chalasr commentedJan 24, 2022
remilemonnier pushed a commit to remilemonnier/symfony that referenced this pull requestJan 25, 2022
remilemonnier pushed a commit to remilemonnier/symfony that referenced this pull requestJan 25, 2022
remilemonnier pushed a commit to remilemonnier/symfony that referenced this pull requestJan 25, 2022
remilemonnier pushed a commit to remilemonnier/symfony that referenced this pull requestJan 27, 2022
remilemonnier pushed a commit to remilemonnier/symfony that referenced this pull requestJan 27, 2022
remilemonnier pushed a commit to remilemonnier/symfony that referenced this pull requestJan 27, 2022
Merged
remilemonnier pushed a commit to remilemonnier/symfony that referenced this pull requestJan 28, 2022
remilemonnier pushed a commit to remilemonnier/symfony that referenced this pull requestFeb 1, 2022
remilemonnier pushed a commit to remilemonnier/symfony that referenced this pull requestFeb 7, 2022
fabpot added a commit that referenced this pull requestMar 26, 2022
…er (remieuronews)This PR was merged into the 6.1 branch.Discussion----------[HttpFoundation] add stale while revalidate cache header| Q | A| ------------- | ---| Branch? | 6.1| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets | Feat (#45036)| License | MIT| Doc PR | [symfony/symfony-docs#... <!-- required for new features -->](symfony/symfony-docs#16445)This PR allow support for RFC5861.Meaning you can now use stale_while_revalidate and stale_if_errorhttps://httpwg.org/specs/rfc5861.htmlVery interesting doc from Fastly on the subject:https://developer.fastly.com/learning/concepts/stale/Link to the issue#45036Commits-------db553fb [cache]#45109 add stale while revalidate and stale if error cache header
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
