NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Finder] Fix finding VCS re-included files in excluded directory#45095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromjulienfalque:gitignore-reincluded-files

Jan 26, 2022

Merged

[Finder] Fix finding VCS re-included files in excluded directory#45095

nicolas-grekas merged 1 commit intosymfony:5.4fromjulienfalque:gitignore-reincluded-files

Jan 26, 2022

Conversation

Copy link

Contributor

julienfalque commentedJan 20, 2022

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	#45048
License	MIT
Doc PR	-

This PR fixes a bug whereFinder would not return a file inside a directory when gitignore rules exclude the directory but re-include the file.

The first commit makesFinder return the file. Though, as shown by the second commit, the directory is still not returned. Strictly speaking, the directoryis ignored, so in some senseFinder is correct. But then it contains a file that is not ignored. In this case, Git would see the directory anyway. ShouldFinder return any ignored directory as soon as it contains a file that is not ignored? Even if that file is not part ofFinder results?