Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Yaml] Improve the deprecation warnings for octal numbers to suggest migrating#45085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stof commentedJan 20, 2022
for now, I provide the full replacement in the deprecation message. this might have a negative effect on the deduplication of deprecations. An alternative could be to mention only the |
8db4f1b to6eca1a4Comparecarsonbot commentedJan 21, 2022
Hey! I think@alexandre-daubois has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
6eca1a4 to4153af6Comparenicolas-grekas commentedJan 26, 2022
Thank you@stof. |
The existing deprecation messages made some people think that octal numbers are totally unsupported in newer Symfony versions (seethephpleague/flysystem-bundle#81). This updates the deprecation message to provide the alternative when using an octal number is intended, to migrate to the Yaml 1.2 way of representing them.