Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Routing] Enrich MissingMandatoryParametersException#45075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@adrienlucas
Copy link
Contributor

QA
Branch?6.1
Bug fix?no
New feature?yes
Deprecations?no
TicketsNA
LicenseMIT
Doc PRNA

This allows to more easily recover after a failing call toUrlGenerator::generate.

deguif reacted with thumbs up emoji
@carsonbotcarsonbot added this to the6.1 milestoneJan 19, 2022
@adrienlucasadrienlucasforce-pushed theenrich-router-missing-parameters-exception branch from2f754c1 toc3b7ed3CompareJanuary 19, 2022 09:49
Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you tell a bit more about the use case?

@adrienlucas
Copy link
ContributorAuthor

Can you tell a bit more about the use case?

I'm using theUrlGenerator::generate to iterate over all the routes and "smoke test" an app. Without this getters, I can still compute the missing parameters but it is less convenient.

@adrienlucasadrienlucasforce-pushed theenrich-router-missing-parameters-exception branch fromc3b7ed3 tob7ef7d1CompareJanuary 19, 2022 10:57
@chalasr
Copy link
Member

Thanks, looks sensible to me. Can you fix fabbot's report?

@adrienlucasadrienlucasforce-pushed theenrich-router-missing-parameters-exception branch 2 times, most recently from22092a1 to166aa54CompareJanuary 19, 2022 11:14
@adrienlucas
Copy link
ContributorAuthor

Thanks, looks sensible to me. Can you fix fabbot's report?

Fixed ! Thank you !

@adrienlucasadrienlucasforce-pushed theenrich-router-missing-parameters-exception branch from166aa54 tob6ae69aCompareJanuary 19, 2022 12:53
@adrienlucasadrienlucasforce-pushed theenrich-router-missing-parameters-exception branch fromb6ae69a tof641c07CompareJanuary 20, 2022 08:33
@adrienlucasadrienlucasforce-pushed theenrich-router-missing-parameters-exception branch 2 times, most recently fromd0c940d to6889a7aCompareJanuary 20, 2022 09:30
@adrienlucasadrienlucasforce-pushed theenrich-router-missing-parameters-exception branch from6889a7a tof562935CompareJanuary 20, 2022 13:50
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One last nitpick and good to me

@adrienlucasadrienlucasforce-pushed theenrich-router-missing-parameters-exception branch fromf562935 to88fb3c9CompareJanuary 20, 2022 13:57
@adrienlucasadrienlucasforce-pushed theenrich-router-missing-parameters-exception branch 2 times, most recently fromcb5bc33 to666069bCompareJanuary 20, 2022 14:11
@adrienlucasadrienlucasforce-pushed theenrich-router-missing-parameters-exception branch 4 times, most recently fromf60704c tocefa8b2CompareJanuary 20, 2022 14:22
@nicolas-grekasnicolas-grekasforce-pushed theenrich-router-missing-parameters-exception branch fromcefa8b2 to35f61aaCompareJanuary 20, 2022 14:29
@nicolas-grekas
Copy link
Member

Thank you@adrienlucas.

@nicolas-grekasnicolas-grekas merged commit5c37c1f intosymfony:6.1Jan 20, 2022
@fabpotfabpot mentioned this pull requestApr 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@HypeMCHypeMCHypeMC left review comments

@stofstofstof requested changes

@chalasrchalasrchalasr approved these changes

+1 more reviewer

@plozmunplozmunplozmun left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

7 participants

@adrienlucas@chalasr@nicolas-grekas@stof@plozmun@HypeMC@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp