NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[PropertyInfo] Add PHP 8.0 promoted properties @param mutation support to PhpDocExtractor#45062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.1fromraphaelvoisin:propertyinfo_phpdoc_promoted_props

Mar 6, 2022

Merged

[PropertyInfo] Add PHP 8.0 promoted properties @param mutation support to PhpDocExtractor#45062

nicolas-grekas merged 1 commit intosymfony:6.1fromraphaelvoisin:propertyinfo_phpdoc_promoted_props

Mar 6, 2022

Conversation

Copy link

Contributor

raphaelvoisin commentedJan 18, 2022

Q	A
Branch?	6.1
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets
License	MIT
Doc PR

By definition, PHP 8 promoted properties are declared in the constructor. Therefore, a new particular case raises when trying to extract (usingPhpDocExtractor) a promoted property that is mutated via@param in the constructor.

class Php80Dummy {    /**     * @param string $promotedAndMutatedProperty     */    public function __construct(private mixed $promotedAndMutatedProperty)    {    }}

$promotedAndMutatedProperty extracted types is currently[null] (because of "mixed"), but IMO should be[string].

However, I'm not sure if this is the intended behaviour for everyone (opinions welcomed). If it is, I guess I should updatePhpDocExtractorTest as well to reflect the new priorities ?