Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Routing] Allow using UTF-8 parameter names#45054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.1fromnicolas-grekas:route-utf8
Jan 19, 2022

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?6.1
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#41909
LicenseMIT
Doc PR-

rvanlaak reacted with hooray emoji
Copy link
Contributor

@fancywebfancyweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Shouldn't we add a changelog entry?

@nicolas-grekas
Copy link
MemberAuthor

Updated, thanks for the review.

@GromNaN
Copy link
Member

A test could be added toRouteTest andRouteCompilerTest to cover this feature.

@nicolas-grekas
Copy link
MemberAuthor

This is already covered by the current test to me.

@stof
Copy link
Member

The change inextractInlineDefaultsAndRequirements is not covered by tests, as you don't use an UTF-8 name on a parameter using inline config (try reverting that part of the diff and see that tests won't fail).
and changes in places computing$hasTrailingVar might need a test using a route using a trailing optional parameter using an UTF-8 name to be covered in a way preventing regression.

@nicolas-grekas
Copy link
MemberAuthor

Tests added@stof

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commitae3b078 intosymfony:6.1Jan 19, 2022
@nicolas-grekasnicolas-grekas deleted the route-utf8 branchJanuary 19, 2022 09:46
@fabpotfabpot mentioned this pull requestApr 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@GromNaNGromNaNGromNaN approved these changes

+1 more reviewer

@fancywebfancywebfancyweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

Route not found with UTF-8 parameter name

6 participants

@nicolas-grekas@GromNaN@stof@fabpot@fancyweb@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp