NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[HttpFoundation] Rename Request::getContentType to getContentTypeFormat#45034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.2fromMarkPedron:issue_39750_request_get_content_type

Jul 22, 2022

Merged

[HttpFoundation] Rename Request::getContentType to getContentTypeFormat#45034

fabpot merged 1 commit intosymfony:6.2fromMarkPedron:issue_39750_request_get_content_type

Jul 22, 2022

Conversation

Copy link

Contributor

MarkPedron commentedJan 15, 2022•
edited by GromNaN
Loading

Q	A
Branch?	6.2
Bug fix?	no
New feature?	yes
Deprecations?	yes
Tickets	Fix#39750
License	MIT
Doc PR	TODO

carsonbot added Status: Needs Review Bug Deprecation Feature labels

Jan 15, 2022

carsonbot added this to the6.1 milestone

Jan 15, 2022

This comment was marked as resolved.

MarkPedron force-pushed theissue_39750_request_get_content_type branch fromefea1a1 tof4409c8Compare

January 15, 2022 18:55

wouterj reviewed

Jan 15, 2022

View reviewed changes

Copy link

Member

wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good from my point of view 👍

src/Symfony/Component/HttpFoundation/Request.php OutdatedShow resolvedHide resolved

MarkPedron force-pushed theissue_39750_request_get_content_type branch 4 times, most recently from59db8a5 toc2c3b20Compare

January 15, 2022 19:30

Copy link

ContributorAuthor

MarkPedron commentedJan 15, 2022

@wouterj Thank you for your kind feedback.

Sorry for all the updates, I completely forgot to add tests and the necessary deprecation infos.

Should be ready now. The CI failure is very mysterious to me.

Copy link

Member

wouterj commentedJan 15, 2022

No problem! For a first contribution, this is in perfect shape (especially considering changes like this need BC and deprecations and stuff).

MarkPedron requested a review fromchalasr as acode owner

January 15, 2022 19:52

Copy link

ContributorAuthor

MarkPedron commentedJan 15, 2022•
edited
Loading

I made an attempt to make appveyor happy (I think i understood the subsequent deprecation emitted in security/http).
The errors in the php8.0/php8.1 job also seem understandable (the return type patch does not apply, because the code changed). However, they seem unrelated to this PR/issue.

MarkPedron force-pushed theissue_39750_request_get_content_type branch fromf949c8c to75daa15Compare

January 15, 2022 20:00

stof reviewed

Jan 17, 2022

View reviewed changes

src/Symfony/Component/HttpFoundation/Tests/RequestTest.php Outdated

		$request = new Request();
		$contentType = $request->getContentTypeFormat();

		$this->assertNull($contentType);

Copy link

Member

stofJan 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Would be great to add more tests covering cases where that method returns a non-null value. Otherwise, we don't really have tests for the feature.

Copy link

ContributorAuthor

MarkPedronApr 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for the suggestion. I added tests to cover the mime typesapplication/json andtext/html

chalasr reviewed

Jan 17, 2022

View reviewed changes

src/Symfony/Component/HttpFoundation/Request.phpShow resolvedHide resolved

ogizanagi reviewed

Jan 17, 2022

View reviewed changes

src/Symfony/Component/HttpFoundation/Request.php OutdatedShow resolvedHide resolved

nicolas-grekas added HttpFoundation and removed Bug labels

Apr 19, 2022

carsonbot changed the title~~Rename Request::getContentType to getContentTypeFormat~~[HttpFoundation] Rename Request::getContentType to getContentTypeFormat

Apr 19, 2022

Copy link

Member

nicolas-grekas commentedApr 19, 2022

Friendly ping@MarkPedron, up to finish this PR? See pending comments + rebase needed.

MarkPedron force-pushed theissue_39750_request_get_content_type branch 2 times, most recently from6b0c8e2 toc092b30Compare

April 26, 2022 19:45

Copy link

ContributorAuthor

MarkPedron commentedApr 26, 2022

@nicolas-grekas Thanks for the reminder. I added non-null tests as suggested, accepted the suggestion expanding the comment, and rebased. If there is anything else to be done, please let me know. I am hesitating to expand the comments further, as to me the meaning of getContentTypeFormat seems quite clear, and confusion arises from the methods setRequestFormat/getRequestFormat, which (to my understanding) refer to the negotiated format of theResponse.

fabpot modified the milestones:6.1,6.2

May 20, 2022

ihmels mentioned this pull request

Jul 19, 2022

[HttpFoundation] RenameRequest::getContentType() togetContentFormat()#46987

Closed

ihmels reviewed

Jul 19, 2022

View reviewed changes

UPGRADE-6.1.md OutdatedShow resolvedHide resolved

ihmels reviewed

Jul 19, 2022

View reviewed changes

src/Symfony/Component/HttpFoundation/Request.php OutdatedShow resolvedHide resolved

fabpot force-pushed theissue_39750_request_get_content_type branch fromc092b30 toccc77fcCompare

July 22, 2022 12:34

Rename getContentType to getContentTypeFormat

f545ed4

Resolves issuesymfony#39750.The method getContentType was confusing.This method does not return a mime type, but a mapped type name derivedfrom the mime type in the CONTENT_TYPE header.

fabpot force-pushed theissue_39750_request_get_content_type branch fromccc77fc tof545ed4Compare

July 22, 2022 12:37

fabpot approved these changes

Jul 22, 2022

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jul 22, 2022

Copy link

Member

fabpot commentedJul 22, 2022

Thank you@MarkPedron.

fabpot mentioned this pull request

Jul 22, 2022

[HttpFoundation] Rename Request::getContentType to getContentTypeFormatsymfony/symfony-docs#17038

Closed

fabpot merged commit57b24fe intosymfony:6.2

Jul 22, 2022

fabpot mentioned this pull request

Oct 24, 2022

Release v6.2.0-BETA1#47972

Merged

MatTheCat mentioned this pull request

Jan 12, 2023

ReplaceRequest::getContentType withRequest::getContentTypeFormat if availableapi-platform/core#5325

Merged

darenas31415 mentioned this pull request

Jan 14, 2023

Fix Symfony 6.2 deprecationqandidate-labs/symfony-json-request-transformer#58

Merged

This was referencedJun 29, 2023

[HttpFoundation] Remove deprecated classes, method and behaviors#50826

Merged

[Security] Remove BC layer for HttpFoundation < 6.2#50827

Merged

nicolas-grekas added a commit that referenced this pull request

Jun 30, 2023

minor#50827[Security] Remove BC layer for HttpFoundation < 6.2 (Gro…

80b5ef8

…mNaN)This PR was merged into the 6.4 branch.Discussion----------[Security] Remove BC layer for HttpFoundation < 6.2| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | n/aIn#45034, a condition was added to support `symfony/http-foundation < 6.2` or use the new `Request::getContentTypeFormat()` method when it exists.I propose to update the minimum version of `symfony/http-foundation` required by `symfony/security-http: 6.4`.`symfony/security-http: 6.4` already requires `symfony/http-kernel: ^6.3|^7.0` [which require](https://github.com/symfony/symfony/blob/6.3/src/Symfony/Component/HttpKernel/composer.json) `symfony/http-foundation: ^6.2.7`The legacy method `Request::getContentType()` will be removed in 7.0 by#50826Commits-------746c3fd Remove BC layer for HttpFoundation < 6.1

nicolas-grekas added a commit that referenced this pull request

Jun 30, 2023

feature#50826[HttpFoundation] Remove deprecated classes, method and…

b7fc8c2

… behaviors (GromNaN)This PR was squashed before being merged into the 7.0 branch.Discussion----------[HttpFoundation] Remove deprecated classes, method and behaviors| Q             | A| ------------- | ---| Branch?       | 7.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | n/aClean `symfony/http-foundation` from all its legacy.- Remove `RequestMatcher` and `ExpressionRequestMatcher`,  deprecated since#47595- Remove `Request::getContentType()`,  deprecated since#45034- Throw a `UnexpectedValueException` or `BadRequestException` when `ParameterBag::filter()` or `InputBag::filter()` reads an invalid value and the flag `FILTER_NULL_ON_FAILURE` is not set.  new behavior announced since#48525- Throw a `InvalidArgumentException` when calling `Request::create()` with a malformed URI,  deprecated since#49376Commits-------665a775 [HttpFoundation] Remove deprecated classes, method and behaviors