Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] Set mtime of cache files 1 year into future if they do not expire#45029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedJan 14, 2022
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Uh oh!
There was an error while loading.Please reload this page.
0)0)0)0)Uh oh!
There was an error while loading.Please reload this page.
0)nicolas-grekas commentedJan 18, 2022
Thank you@Blacksmoke16. |
…y do not expire (Blacksmoke16)This PR was squashed before being merged into the 4.4 branch.Discussion----------[Cache] Set mtime of cache files 1 year into future if they do not expire| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? |no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -#26127 made is so that `0` is used to represent cache files that do not expire. However this was causing `touch` to be called with `0`, which was setting the create/modification time of the file to start of epoch time, which doesn't really make sense. It can cause some issues with `tar` for example as when timezones are taken into consideration you end up with warnings like:> tar: app/cache/prod/annotations/@/+/3/cdcAWwqaPORAi0TfsO5Q: implausibly old time stamp 1969-12-31 19:00:00Given the expiration of the files is stored within the file itself, it's probably safe to not `touch` it if that value is `0`. However is there actually a reason to touch it at all as a file that expires in 6 hours would show as created 6 hours into the future.I also wasn't sure how to test this, so open to suggestions on that/if we need the `touch` at all.Commits-------57cad6f [Cache] Set mtime of cache files 1 year into future if they do not expire
acb5b0f to57cad6fCompare
#26127 made is so that
0is used to represent cache files that do not expire. However this was causingtouchto be called with0, which was setting the create/modification time of the file to start of epoch time, which doesn't really make sense. It can cause some issues withtarfor example as when timezones are taken into consideration you end up with warnings like:Given the expiration of the files is stored within the file itself, it's probably safe to not
touchit if that value is0. However is there actually a reason to touch it at all as a file that expires in 6 hours would show as created 6 hours into the future.I also wasn't sure how to test this, so open to suggestions on that/if we need the
touchat all.