NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[DoctrineBridge] Fix invalid guess with enumType#45012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:4.4fromjderusse:doctrine-enumType

Jan 14, 2022

Merged

[DoctrineBridge] Fix invalid guess with enumType#45012

nicolas-grekas merged 1 commit intosymfony:4.4fromjderusse:doctrine-enumType

Jan 14, 2022

Conversation

Copy link

Member

jderusse commentedJan 13, 2022

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

Sincedoctrine/orm#9304 doctrine allows Enums with the newenumType option.
ie.

#[ORM\Column(type:'string', enumType: Status::class, length:1)]public Status$status;

The issue is, it break validations at several places:

doctrinerExtractor guess it's astring (Because oftype = string), and validation adds the constraintAssert\Type(string)
doctrineLoader guess it's a string with a maxLength and validation adds a constrainAssert\Length(max=1)

jderusse requested a review fromdunglas as acode owner

January 13, 2022 14:34

carsonbot added Status: Needs Review Bug labels

Jan 13, 2022

carsonbot added this to the4.4 milestone

Jan 13, 2022

jderusse force-pushed thedoctrine-enumType branch fromff5d94d to8171050Compare

January 13, 2022 14:36

jderusse added the DoctrineBridge label

Jan 13, 2022

carsonbot changed the title~~Fix invalid guess with enumType~~[DoctrineBridge] Fix invalid guess with enumType

Jan 13, 2022

jderusse force-pushed thedoctrine-enumType branch from8171050 todd632d5Compare

January 13, 2022 14:41

Fix invalid guess with enumType

68dd218

jderusse force-pushed thedoctrine-enumType branch fromdd632d5 to68dd218Compare

January 13, 2022 14:51

Copy link

jonag commentedJan 13, 2022

I was playing with the last version of Doctrine this afternoon and ran into this exact issue. This also prevent the Serializer to correctly denormalize an object which one of its property is an enum.

I was looking for a way to fix this but you were faster. Anyway, I tried your patch and it works like a charm, thank you 👌 !