NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Runtime] Fix --env and --no-debug with dotenv_overload#44997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:5.4fromfancyweb:runtime/dotenv-overload-cmd

Jan 26, 2022

Merged

[Runtime] Fix --env and --no-debug with dotenv_overload#44997

nicolas-grekas merged 1 commit intosymfony:5.4fromfancyweb:runtime/dotenv-overload-cmd

Jan 26, 2022

Conversation

Copy link

Contributor

fancyweb commentedJan 12, 2022

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

With thedotenv_overload option enabled, commands--no-debug and--env=prod options are not honored.

carsonbot added Status: Needs Review Bug Runtime labels

Jan 12, 2022

carsonbot added this to the5.4 milestone

Jan 12, 2022

fancyweb force-pushed theruntime/dotenv-overload-cmd branch fromc6b65cb tof91f18bCompare

January 12, 2022 13:44

GromNaN reviewed

Jan 12, 2022

View reviewed changes

src/Symfony/Component/Runtime/SymfonyRuntime.php OutdatedShow resolvedHide resolved

fancyweb force-pushed theruntime/dotenv-overload-cmd branch 2 times, most recently fromfb41341 to97a5714Compare

January 12, 2022 15:25

chalasr approved these changes

Jan 26, 2022

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jan 26, 2022

nicolas-grekas reviewed

Jan 26, 2022

View reviewed changes

src/Symfony/Component/Runtime/SymfonyRuntime.php OutdatedShow resolvedHide resolved

fancyweb force-pushed theruntime/dotenv-overload-cmd branch from97a5714 to0afd743Compare

January 26, 2022 17:31

[Runtime] Fix --env and --no-debug with dotenv_overload

0460f81

fancyweb force-pushed theruntime/dotenv-overload-cmd branch from0afd743 to0460f81Compare

January 26, 2022 17:32

Copy link

Member

nicolas-grekas commentedJan 26, 2022

Thank you@fancyweb.

nicolas-grekas merged commit5bb11d5 intosymfony:5.4

Jan 26, 2022

fancyweb deleted the runtime/dotenv-overload-cmd branch

January 26, 2022 17:34

This was referencedJan 28, 2022

Release v5.4.3#45217

Merged

Release v6.0.3#45220

Merged

fancyweb mentioned this pull request

Feb 15, 2022

[Runtime] Fix dotenv_overload with commands#45426

Merged

nicolas-grekas added a commit that referenced this pull request

Feb 15, 2022

bug#45426[Runtime] Fix dotenv_overload with commands (fancyweb)

20111d2

This PR was merged into the 5.4 branch.Discussion----------[Runtime] Fix dotenv_overload with commands| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | -| Tickets       | -| License       | MIT| Doc PR        | -Fixes bugs introduced in#44997.For example, if `$_SERVER['APP_ENV'] = 'foo';` exists and with `APP_ENV=prod` in `.env`, any command will throw `Cannot use "--env" or "-e" when the...` because `foo` is considered as the input env.Determining the input env and debug from `$_SERVER` is wrong because when the `--no-debug` and `--env` are not used, we actually consider the existing env and debug as the input end and debug. We need to know and use the real input env and debug.Commits-------4075269 [Runtime] Fix dotenv_overload with commands