NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[DependencyInjection] copy synthetic status when resolving child definitions#44986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:4.4fromkbond:di-child-synthetic-service

Jan 19, 2022

Merged

[DependencyInjection] copy synthetic status when resolving child definitions#44986

nicolas-grekas merged 1 commit intosymfony:4.4fromkbond:di-child-synthetic-service

Jan 19, 2022

Conversation

Copy link

Member

kbond commentedJan 11, 2022

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#44972
License	MIT
Doc PR	n/a

Appears to be the simplest fix for#44972. The only place this appears to be a problem is when using thelint:container command with an auto-configured kernel in 5.3+.

carsonbot added Status: Needs Review Bug DependencyInjection labels

Jan 11, 2022

carsonbot added this to the4.4 milestone

Jan 11, 2022

Copy link

Member

nicolas-grekas commentedJan 12, 2022

I'd prefer doing that in ResolveInstanceofConditionalsPass. Doable?

Copy link

MemberAuthor

kbond commentedJan 12, 2022

I'll need some direction for where to do this inResolveInstanceofConditionalsPass. I tried a few different places but no luck.

Copy link

Member

nicolas-grekas commentedJan 12, 2022

just after$definition->setParent($parent);?

Copy link

MemberAuthor

kbond commentedJan 12, 2022•
edited
Loading

The definition is still synthetic at this point - this is being copied when converting toChildDefinition. It's not beingcopied back inResolveChildDefinitionsPass.