Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Resolve handled classes when only method in tag is provided#44971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@angelov
Copy link
Contributor

@angelovangelov commentedJan 10, 2022•
edited by ogizanagi
Loading

QA
Branch?6.1
Bug fix?no
New feature?yes
Deprecations?no
Tickets/
LicenseMIT
Doc PR/

When tagging Messenger handlers, if themethod attribute is set, the compiler pass does not resolve the message type before handling it - it requires thehandles attribute to be set as well.

With this PR, the message type is being resolved even if method other than__invoke is being used.

I'm not sure if this is a bug fix or just an improvement :/

ro0NL reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@angelovangelovforce-pushed themessenger-resolve-message-type-when-custom-method branch fromb0c3eae toaedddfeCompareJanuary 10, 2022 19:32
@carsonbot
Copy link

Hey!

I think@monteiro has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@ogizanagi
Copy link
Contributor

I think this should go to 6.1 as a DX improvement. It does not qualify as a bug fix.

@ogizanagiogizanagi modified the milestones:5.4,6.1Jan 11, 2022
@angelovangelov changed the base branch from5.4 to6.1January 11, 2022 19:16
@angelovangelov changed the base branch from6.1 to5.4January 11, 2022 19:16
@angelovangelov changed the base branch from5.4 to6.1January 11, 2022 19:21
@angelovangelovforce-pushed themessenger-resolve-message-type-when-custom-method branch 2 times, most recently fromd49d490 tof69f116CompareJanuary 11, 2022 19:40
@angelov
Copy link
ContributorAuthor

I think this should go to 6.1 as a DX improvement. It does not qualify as a bug fix.

Thanks! I though the same, but wasn't sure. I updated the PR to point towards 6.1

@angelovangelovforce-pushed themessenger-resolve-message-type-when-custom-method branch fromede276e to8d12870CompareJanuary 11, 2022 22:38
@angelov
Copy link
ContributorAuthor

angelov commentedJan 12, 2022•
edited
Loading

The failures in the checks seem unrelated to me?

@ogizanagi
Copy link
Contributor

@angelov : Could you add an entry about this in the Messenger CHANGELOG.md 6.1 section ?
Also, great first-time contrib 👌🏻

@angelov
Copy link
ContributorAuthor

@ogizanagi thanks!

Updated the changelog, I hope it's alright.

@ogizanagiogizanagiforce-pushed themessenger-resolve-message-type-when-custom-method branch fromd71ec58 to780b7daCompareJanuary 14, 2022 05:47
@ogizanagi
Copy link
Contributor

Thank you@angelov.

@ogizanagiogizanagi merged commite875021 intosymfony:6.1Jan 14, 2022
@angelovangelov deleted the messenger-resolve-message-type-when-custom-method branchJanuary 14, 2022 08:54
@fabpotfabpot mentioned this pull requestApr 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrchalasr approved these changes

+2 more reviewers

@stloydstloydstloyd left review comments

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

5 participants

@angelov@carsonbot@ogizanagi@stloyd@chalasr
[8]ページ先頭
©2009-2025 Movatter.jp