Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Validator] Multi decimal to alpha for CssColor validator#44967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedJan 10, 2022
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
welcoMattic commentedJan 10, 2022
Hi@tilimac, thank you and congrats for your 1st contribution! |
tilimac commentedJan 10, 2022
Thanks you ! |
stof commentedJan 10, 2022
And the CI tells me that your change is wrong, which is also expected when looking at your diff where you add an unescaped Also, you should add test cases covering the cases for which you add support, to prevent regressions. |
tilimac commentedJan 10, 2022
Mmmh, i don't understand why checks not work with php 8.0 |
src/Symfony/Component/Validator/Constraints/CssColorValidator.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
tilimac commentedJan 11, 2022
i prepare test cases |
fabpot commentedFeb 25, 2022
Thank you@tilimac. |
Add multi decimal to alpha value (rgba and hsla) for CssColor validator