Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Validator] Multi decimal to alpha for CssColor validator#44967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromtilimac:5.4
Feb 25, 2022

Conversation

@tilimac
Copy link

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#44966
LicenseMIT
Doc PRsymfony/symfony-docs#...

Add multi decimal to alpha value (rgba and hsla) for CssColor validator

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@welcoMattic
Copy link
Member

Hi@tilimac, thank you and congrats for your 1st contribution!
Can you add some tests to cover this modification?

@carsonbotcarsonbot changed the titleMulti decimal to alpha for CssColor validator[Validator] Multi decimal to alpha for CssColor validatorJan 10, 2022
@tilimac
Copy link
Author

Thanks you !
I tested my modifications on this site
https://regex101.com/r/5gQ8QQ/1

@stof
Copy link
Member

And the CI tells me that your change is wrong, which is also expected when looking at your diff where you add an unescaped/ in the middle of a regexp using/ delimiters. I guess the regexp you tested is not actually the same than your diff.

Also, you should add test cases covering the cases for which you add support, to prevent regressions.

@tilimac
Copy link
Author

Mmmh, i don't understand why checks not work with php 8.0

@tilimac
Copy link
Author

i prepare test cases

@fabpot
Copy link
Member

Thank you@tilimac.

tilimac reacted with heart emoji

@fabpotfabpot merged commitd2ab9cf intosymfony:5.4Feb 25, 2022
This was referencedFeb 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofAwaiting requested review from stof

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@tilimac@carsonbot@welcoMattic@stof@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp