Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DependencyInjection] Fix nested env var with resolve processor#44932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
GromNaN merged 1 commit intosymfony:4.4fromLaulibrius:ticket_44756
Jan 7, 2022

Conversation

@Laulibrius
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#44756
LicenseMIT
Doc PR

This PR fixes the issue raised by@ro0NL. (see Description)
I added some tests but i'm not confident about how to check with real environment variables.

This is my first PR, i hope i'm not doing it wrong.

ro0NL reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@ro0NL
Copy link
Contributor

ro0NL commentedJan 6, 2022•
edited
Loading

IMHO this is correct behavior. It took some time to understand why the workaround was needed, when reviewing a PR on our side.

Im not sure about changing the behavior in a patch release. 6.1 + changelog works for us 👍

@Laulibrius
Copy link
ContributorAuthor

Im not sure about changing the behavior in a patch release. 6.1 + changelog works for us 👍

I first did it on 6.1 but then you said it's a bug in your opinion so i followed the rules and switch to 4.4 to make this PR 😁
I can switch back to 6.1 but i'm not sure what to write in the changelog... 🤔

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Works for me as a bugfix, thanks for the PR.

Copy link
Contributor

@fancywebfancyweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That's some nice tests 👏

kbond reacted with thumbs up emojiLaulibrius reacted with heart emoji
@GromNaN
Copy link
Member

Thanks for fixing this bug Laurent.

@GromNaNGromNaN merged commit7b32f97 intosymfony:4.4Jan 7, 2022
This was referencedJan 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@GromNaNGromNaNGromNaN approved these changes

+1 more reviewer

@fancywebfancywebfancyweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@Laulibrius@carsonbot@ro0NL@GromNaN@nicolas-grekas@fancyweb
[8]ページ先頭
©2009-2025 Movatter.jp