Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Mailer] Add downloadable attachments to profiler#44917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@dbrekelmans
Copy link
Contributor

@dbrekelmansdbrekelmans commentedJan 5, 2022
edited
Loading

QA
Branch?6.1
Bug fix?no
New feature?yes
Deprecations?no
Ticketsn/a
LicenseMIT
Doc PRn/a

This PR allows developers to download email attachments from the profiler. This is very useful for debugging if you are sending emails with PDF attachments for example, and you want to check some data within the attachment through the profiler.

ro0NL and OskarStark reacted with thumbs up emoji
@kbond
Copy link
Member

Should I create a new CHANGELOG-6.1.md?

Only the component/bundle/bridge changelogs need to be updated for new features.

@kbond
Copy link
Member

Can this be done without the need for a controller/temp files using data URIs to embed the file in an anchor tag or is there anotherfrontend-only solution?

Could this work?https://stackoverflow.com/questions/283956/is-there-any-way-to-specify-a-suggested-filename-when-using-data-uri

@dbrekelmans
Copy link
ContributorAuthor

@kbond If I remember correctly, I tried embedding it in the url (I built this about a year ago, so not entirely sure). I believe it causes issues when the content is too big and it gets cut off from the url by the browser.

@kbond
Copy link
Member

kbond commentedJan 5, 2022
edited
Loading

I just tried with a larger pdf (700kb) and it worked in the latest chrome/firefox:

<ahref="data:application/pdf;base64,{{pdfContentsBase64Encoded }}"download="desired-filename.pdf">Download</a>

Copy link
Member

@kbondkbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a great feature!

Few minor things.@dbrekelmans, did you test this in the context of a "real app"?

@dbrekelmans
Copy link
ContributorAuthor

@kbond Sorry for the late response, I got a bit distracted.

did you test this in the context of a "real app"?

Yes, I just tested it again with the code changes. Seems to work perfectly :)

kbond reacted with heart emoji

@fabpotfabpotforce-pushed themailer-profiler-attachment-files branch from3b8145e to4320220CompareJanuary 19, 2022 16:02
@fabpot
Copy link
Member

Thank you@dbrekelmans.

@fabpotfabpot merged commit19e99a6 intosymfony:6.1Jan 19, 2022
@fabpotfabpot mentioned this pull requestApr 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@kbondkbondkbond approved these changes

@stofstofAwaiting requested review from stof

+1 more reviewer

@ro0NLro0NLro0NL left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

6 participants

@dbrekelmans@kbond@fabpot@stof@ro0NL@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp